[
https://issues.apache.org/jira/browse/TRINIDAD-712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12527920
]
Adam Winer commented on TRINIDAD-712:
-------------------------------------
Simon, Andrew: the methods are not final for performance; there would be no
significant boost. The only reason to ever make classes and methods final is
for design reasons.
The methods are final ENTIRELY because of the FacesBean architecture. The
generated JSP tags write directly to the FacesBean, bypassing the set methods.
The renderers read directly from the FacesBean, bypassing the get methods.
Overriding the getters and setters would therefore be completely pointless in
the current architecture. We could debate (on [EMAIL PROTECTED]) whether the
JSP tags and renderers should do what they do, but it would be very bad to let
people think they can override these accessors, when in fact they cannot.
> Do not generate final properties with the maven-faces-plugin
> ------------------------------------------------------------
>
> Key: TRINIDAD-712
> URL: https://issues.apache.org/jira/browse/TRINIDAD-712
> Project: MyFaces Trinidad
> Issue Type: Wish
> Components: Plugins
> Affects Versions: 1.0.2-plugins
> Environment: maven-faces-plugin version 1.0.2 from the maven
> repository
> Reporter: Andrew Robinson
> Assignee: Adam Winer
>
> It would be extremely beneficial to not have property methods generated as
> final by the maven-faces-plugin.
> IMO, final should be reserved for constants and only on methods with rare
> exceptions and good reasons.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
