---- Matthias Wessendorf <[EMAIL PROTECTED]> schrieb: > On Dec 20, 2007 12:36 PM, Simon Kitching <[EMAIL PROTECTED]> wrote: > > But the source download for myfaces really should include the shared > > classes too. The .class files are in the myfaces impl jar, so the > > (repackaged) sources should be in the corresponding source jarfile. > > currently the sources are "just" sources for the module; > an enhancement would be nice, sure.
Well, it depends on whether you count the stuff pulled in from shared-impl as part of the "sources" of the module or not. I think there is a good reason for saying they are. Ideally, the build process would not be the shared project generating impl, tomahawk, etc versions but instead other projects pulling a standard shared-sources.jar file, then doing the package-munging themselves, effectively "importing" the source. > > > > > I would *really* like to see this fixed for the next release. It's a pain > > to be stepping through code and then not be able to find the source without > > adding a source jar that is not part of the declared dependencies at all.. > > yes, I agree; feel free to add this :-) The shared code is unpacked into the target dir as part of the build process. So it is just a matter of including that dir when building the source jar. Should be 1 or 2 lines in the pom. I won't be able to get this done in the next week; work xmas party tonight then leave on holiday for about a week at 6am tomorrow morning. It would be great if someone else could have a go at this. Regards, Simon
