No - if you are building with 1.6, it won't. Only the language level is checked.

regards,

Martin

On 12/20/07, Matthias Wessendorf <[EMAIL PROTECTED]> wrote:
> On Dec 20, 2007 2:45 PM,  <[EMAIL PROTECTED]> wrote:
> > Author: skitching
> > Date: Thu Dec 20 05:45:06 2007
> > New Revision: 605927
> >
> > URL: http://svn.apache.org/viewvc?rev=605927&view=rev
> > Log:
> > Remove accidental use of java 1.6 method String.isEmpty
>
> isn't the build catching this ?
>
> -M
>
> >
> > Modified:
> >
> myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/dateformat/SimpleDateFormatter.java
> >
> > Modified:
> myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/dateformat/SimpleDateFormatter.java
> > URL:
> http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/dateformat/SimpleDateFormatter.java?rev=605927&r1=605926&r2=605927&view=diff
> >
> ==============================================================================
> > ---
> myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/dateformat/SimpleDateFormatter.java
> (original)
> > +++
> myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/dateformat/SimpleDateFormatter.java
> Thu Dec 20 05:45:06 2007
> > @@ -838,7 +838,7 @@
> >
> >      private static void formatPattern(DateFormatSymbols symbols,
> ParserContext context, String patternSub, boolean yearIsWeekYear,
> StringBuffer out)
> >      {
> > -        if ((patternSub == null) || (patternSub.isEmpty()))
> > +        if ((patternSub == null) || (patternSub.length() == 0))
> >          {
> >              return;
> >          }
> > @@ -1137,7 +1137,7 @@
> >
> >      public Date parse(String dateStr)
> >      {
> > -        if ((dateStr==null) || dateStr.isEmpty())
> > +        if ((dateStr==null) || (dateStr.length() == 0))
> >              return null;
> >
> >          ParserContext context = parseOps(symbols, yearIsWeekYear,
> firstDayOfWeek, ops, dateStr);
> >
> >
> >
>
>
>
> --
> Matthias Wessendorf
>
> further stuff:
> blog: http://matthiaswessendorf.wordpress.com/
> sessions: http://www.slideshare.net/mwessendorf
> mail: matzew-at-apache-dot-org
>


-- 

http://www.irian.at

Your JSF powerhouse -
JSF Consulting, Development and
Courses in English and German

Professional Support for Apache MyFaces

Reply via email to