Hi Bernd, I've finished with the major changes in tidying up the Codehaus apt-maven-plugin if you fancy taking a look:
http://svn.codehaus.org/mojo/trunk/sandbox/apt-maven-plugin/ Major changes: - Manually merged in any exclusive features I could see in the Tobago version - Big refactor to simplify code - Added integration test intrastructure with a few tests to start with - Supported plugin dependencies (TOBAGO-130/MOJO-1072) I've also just removed any Java compliation support from the plugin since I couldn't see any advantage of duplicating this with the maven-compiler-plugin. Can you see any problems with that? A few further points I'd like to ask you about: 1) Do you use extra source roots? I'm tempted to remove this parameter since it tends to go against the standard of using the project's current source roots. 2) Do you use the resource target path parameter? I'd have thought that the apt factory should control this. 3) Do you use the target files parameter? I wouldn't have thought you'd need such fine-grained control of source files to process when using Maven. 4) Do you use staleness checking? I'm not too convinced by this implementation since it checks source files against class files to determine staleness. This is a problem when using -nocompile as the class file timestamp has no correlation with the staleness of generated resources. Auto-compiling IDEs then also pose a further problem since they never let a class file become stale, hence resources are never generated with apt. I'd be interested in any feedback on using this plugin with Tobago. Feel free to move any existing JIRA issues across to the apt component in MOJO: http://jira.codehaus.org/browse/MOJO/component/13192 Cheers, Mark On 27/03/2008, Bernd Bohmann <[EMAIL PROTECTED]> wrote: > Ok, I'm waiting for your reply. > > > Regards > > Bernd > > Mark Hobson schrieb: > > Hi Bernd, > > > > Thanks for the reply. I glad that you agree that merging the plugins > > is the way forward. > > > > I've started manually adding the features unique to the Tobago plugin > > to the Codehaus version and am currently tidying up the code. It's > > probably best to wait until I've finished doing that before submitting > > any patches; I'll let you know when it's ready for trialling with > > Tobago. > > > > Cheers, > > > > Mark > > > > On 27/03/2008, Bernd Bohmann <[EMAIL PROTECTED]> wrote: > >> Hello Mark, > >> > >> I think merging the plugin is a good idea. > >> > >> I hope I get enough time to prepare patches for the missing features in > >> the codehaus apt plugin. > >> > >> The fist step would be using the apt-maven-plugin in the tobago build > >> instead of the own plugin. > >> > >> Regards > >> > >> Bernd > >> > >> Mark Hobson schrieb: > >> > >>> Hi there, > >> > > >> > I was looking for a Maven APT plugin and came across Tobago's and also > >> > one over at Codehaus [1]. I'm not aware of the history of these two > >> > plugins, but they both appear to be forked from the same codebase and > >> > been worked on over time. I'd like to see these plugins merged > >> > together to avoid duplicating efforts by both parties; if this of > >> > interest? > >> > > >> > I think the natural home for this plugin would be at Codehaus, which > >> > Tobago could easily use. I'm happy to help out merging the two > >> > codebases together since I have commit rights over at Codehaus. I've > >> > already fixed TOBAGO-130 as MOJO-1072 [2], so hopefully this merge > >> > will be beneficial to both parties. > >> > > >> > Let me know if you're interested and how you'd see the process moving > forward. > >> > > >> > Cheers, > >> > > >> > Mark > >> > > >> > [1] http://mojo.codehaus.org/apt-maven-plugin/ > >> > [2] http://jira.codehaus.org/browse/MOJO-1072 > >> > > >> > > >
