[
https://issues.apache.org/jira/browse/MYFACES-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12597713#action_12597713
]
Simon Kitching commented on MYFACES-434:
----------------------------------------
As noted in this thread, there are some significant other issues with this
patch.
http://markmail.org/message/bknubhi7xixi2ra6
Most significantly, there are some "todo" comments in this code that appear
very important, ie the new code appears to currently not support functionality
that the old code had
In addition.
* documentation is badly lacking.
* the code is fairly ugly; some refactoring would be good.
This patch has a major impact upon a large number of tomahawk components. And
because it automatically installs a wrapper around every FacesContext and
ExternalContext object it can (and did) screw up application behaviour totally
unrelated to Tomahawk. Patches like this need very careful review before
committing - and preferably lots of logging so that when something goes wrong
it is obvious.
I will try to find time to review this code myself (including finding a better
fix than the patch recently committed to solve the delegate.release bug. But it
would be nice for such intrusive patches to get more review before being
committed...
> MyFaces's Portlet enhancement
> -----------------------------
>
> Key: MYFACES-434
> URL: https://issues.apache.org/jira/browse/MYFACES-434
> Project: MyFaces Core
> Issue Type: Improvement
> Components: Portlet_Support
> Affects Versions: 1.1.0
> Environment: LInux, J2SE 1.4.2
> Reporter: Shinsuke SUGAYA
> Assignee: Martin Marinschek
> Fix For: 1.1.6-SNAPSHOT
>
> Attachments: PortletEnableTomahawk.patch, tomahawk-patch-portlet.zip,
> Tomahawk_FileUpload_IBMPortal.zip
>
>
> MyFacesGenericPortlet does not fully support the feature of tomahawk
> component, such as inputHtml and fileUpload. So, I request the following
> feature to run it on portlet:
> - support tags in <head> (ex. inputHtml component)
> - support upload (fileUpload component)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
