[
https://issues.apache.org/jira/browse/TOMAHAWK-1266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607298#action_12607298
]
Simon Kitching commented on TOMAHAWK-1266:
------------------------------------------
Yes, there are some minor unit test changes needed too. I have already done
that, but did not bother to attach the patch as I was really just expecting
people to look at the patch rather than try to run it :-)
What I'm really looking for feedback on is whether simply throwing an exception
for relative paths with inline or filtered is ok. Mario has had a look and
things that is fine.
It will break user code that:
* enables filtering or inline, AND
* uses a relative path to the referenced file, AND
* where the including file is in the root dir of the webapp (otherwise it
would never have worked in the first place)
It's not common, the error message from this patch makes it pretty obvious what
the issue is, and it is trivial for users to fix. So I hope people are ok with
that.
I'll try to get that test patch uploaded in the next hour or so. Unless you
(Leonardo) are happy with this, in which case I'll just commit it all tomorrow.
It definitely fixes the new bug, but I haven't verified that the old bug the
original patch was for has remained fixed.
> t:stylesheet renders link to an empty page on tomcat-5.5.24 and above
> ---------------------------------------------------------------------
>
> Key: TOMAHAWK-1266
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1266
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Stylesheet
> Affects Versions: 1.1.5
> Environment: linux, tomcat, myfaces-1.1.5, tomahawk-1.1.5
> Reporter: Ronald Müller
> Assignee: Leonardo Uribe
> Fix For: 1.1.7-SNAPSHOT
>
> Attachments: stylesheet-patch.txt, StyleTest.war
>
>
> on tomcat-5.5.24 and above (also 6.0.x) t:stylesheet with filter-attribute
> set to 'true' renders a style-link that links to an empty page. without
> filtering everything works fine since t:stylesheet renders direct links to
> the css-files (not using the extension-filter).
> maybe this issue is related to the extension filter or it is a tomcat-issue
> only. since it definitely happens first time with tomcat-version 5.5.24.
> (5.0.x-5.5.23 working fine).
> i'll provide a minimal test-case as war-file. just deploy and request
> 'http://localhost:8080/StyleTest/styletest.faces'.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
