[ 
https://issues.apache.org/jira/browse/TOMAHAWK-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607496#action_12607496
 ] 

Christian Kaltepoth commented on TOMAHAWK-64:
---------------------------------------------

Thank you very much for looking into the patch and applying it to tomahawk12.
I'm sorry I didn't notice the problem of the broken example in htmlTag.jsp
with core11.

One last question just to clear things up: I am aware of the problem with
HTML code and f:verbatim tags in the 1.1 spec. So it seems to me, that the
original code in htmlTag.jsp isn't correct:

<t:htmlTag value="h1"><b>h1</b> tag.</t:htmlTag>

As HTML code has to be surrounded by a f:verbatim tag, this code should look 
like this:

<t:htmlTag value="h1"><f:verbatim><b>h1</b> tag.</f:verbatim></t:htmlTag>

In this case my code works without issues. The version without f:verbatim tags
seems to break, because the component was modified to render the children 
itself.

Unfortunately the patch would certainly break existing JSF 1.1 pages that were 
build
according to the old example.


> Allow t:htmlTag to support an attributes string.
> ------------------------------------------------
>
>                 Key: TOMAHAWK-64
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-64
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Html Tag
>            Reporter: Michael Rimov
>            Assignee: Leonardo Uribe
>            Priority: Minor
>             Fix For: 1.1.7-SNAPSHOT
>
>         Attachments: htmltag_param_feature.patch
>
>
> I would really like to see <t:htmlTag> to allow html attributes to be passed 
> into the html tag.
> A concrete example:
> <td colspan="2">
> Hello World
> </td>   
> Would Ideally (to me) be converted to:
> <t:htmlTag value="td" attributes="colspan='2'">
>    <h:outputText value="Hello World"/>
> </t:htmlTag>
> Thanks! :)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to