Hi
Alias property only receive el expression. There was a mistake on a commit
the example page, which was reverted (sorry!). Alias never receive string
only values. The change applied throws an expression when alias="someString"
instead alias="#{somebean}". Previously other non descriptive error is
thrown when alias="someString"
regards
Leonardo Uribe
On Tue, Jun 24, 2008 at 1:50 AM, Mario Ivankovits <[EMAIL PROTECTED]> wrote:
> Hi!
>
> Doesn't this change break backward compatibility completley?
>
> The value of the alias="" attribute now has to be defined differently,
> instead of the el-expressesion just the name needs to be set.
> Even if this change is logical to me, a new tomahawk release will break any
> existing application using the aliasBean, no?
>
> If so, I think this patch needs to be reverted unless we are going to
> release a new major version of tomahawk.
>
> Ciao,
> Mario
>
> [EMAIL PROTECTED] schrieb:
>
>> Author: lu4242
>> Date: Mon Jun 23 21:22:49 2008
>> New Revision: 671015
>>
>> URL: http://svn.apache.org/viewvc?rev=671015&view=rev
>> Log:
>> TOMAHAWK-790 Aliasbean warning/error when no EL expression in the alias
>> property
>>
>> Modified:
>>
>>
>> myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/aliasbean/AliasBeanTag.java
>> myfaces/tomahawk/trunk/examples/simple/src/main/webapp/aliasBean.jsp
>>
>> Modified:
>> myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/aliasbean/AliasBeanTag.java
>> URL:
>> http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/aliasbean/AliasBeanTag.java?rev=671015&r1=671014&r2=671015&view=diff
>>
>> ==============================================================================
>> ---
>> myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/aliasbean/AliasBeanTag.java
>> (original)
>> +++
>> myfaces/tomahawk/trunk/core/src/main/java/org/apache/myfaces/custom/aliasbean/AliasBeanTag.java
>> Mon Jun 23 21:22:49 2008
>> @@ -47,7 +47,7 @@
>> protected void setProperties(UIComponent component) {
>> super.setProperties(component);
>> - setStringProperty(component, "alias", _alias);
>> + setValueBinding(component, "alias", _alias);
>> setStringProperty(component, "value", _valueExpression);
>> }
>>
>> Modified:
>> myfaces/tomahawk/trunk/examples/simple/src/main/webapp/aliasBean.jsp
>> URL:
>> http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/examples/simple/src/main/webapp/aliasBean.jsp?rev=671015&r1=671014&r2=671015&view=diff
>>
>> ==============================================================================
>> --- myfaces/tomahawk/trunk/examples/simple/src/main/webapp/aliasBean.jsp
>> (original)
>> +++ myfaces/tomahawk/trunk/examples/simple/src/main/webapp/aliasBean.jsp
>> Mon Jun 23 21:22:49 2008
>> @@ -45,7 +45,7 @@
>> <h:form>
>> <h2>aliasTest1</h2>
>> - <t:aliasBean alias="#{holder}" value="#{aliasTest1}">
>> + <t:aliasBean alias="holder" value="#{aliasTest1}">
>> <f:subview id="simulatedIncludedSubform1">
>> <%-- The next tags could be inserted by an %@ include or
>> jsp:include --%>
>> <h:outputLabel for="name" value="Name :"/>
>>
>>
>>
>>
>
>
