[
https://issues.apache.org/jira/browse/ORCHESTRA-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607762#action_12607762
]
Bernhard Huemer commented on ORCHESTRA-17:
------------------------------------------
I've created a patch that is similiar to the one Martin has provided a while
ago but I've extended it a little bit as it is unlike the previous version now
compatible with both JSF 1.1 and JSF 1.2 (thanks to a small "hack"). Even
though I could commit it myself I'd like someone else to review it (Simon or
Mario?). I've already tested it with Apache Pluto and the JSR-301 Portlet
Bridge.
> RequestParameterFacesContextFactory only works with HttpServletResponse
> -----------------------------------------------------------------------
>
> Key: ORCHESTRA-17
> URL: https://issues.apache.org/jira/browse/ORCHESTRA-17
> Project: MyFaces Orchestra
> Issue Type: Bug
> Components: RequestParameterProvider
> Affects Versions: 1.0, 1.1
> Environment: Liferay Portlet Container
> Reporter: Martin Marinschek
> Attachments: ORCHESTRA-17.patch
>
>
> The following snippet wrongly casts to HttpServletResponse, therefore
> portlet-environments will not work:
> if (response instanceof HttpServletResponse)
> {
> HttpServletRequest httpServletRequest = (HttpServletRequest)
> request;
>
> // Wrap this request only if something else (eg a
> RequestParameterServletFilter) has not already wrapped it.
> if
> (!Boolean.TRUE.equals(httpServletRequest.getAttribute(RequestParameterServletFilter.REQUEST_PARAM_FILTER_CALLED)))
> {
>
> I will commit a solution very soon.
> regards,
> Martin
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
