Simon, Do you have a number? How many files do have tab characters? I think (b - fix them) would be the better solution. But only if that does not change every second file. --Manfred
On Wed, Jul 2, 2008 at 7:28 PM, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > Hi All, > > In the new checkstyle rules file I enabled checks for tab characters, as the > myfaces convention is (AFAIK) to use 4 spaces, not tabs. However the > checkstyle report points out a lot of files containing tabs. > > It's no big deal, but do we want to: > (a) disable the checkstyle rule and ignore tabs or > (b) fix them? > > Tabs are a minor nuisance when viewing the source as some tools render 4 > spaces, some 8. > > I've written a simple shellscript that can clean this up very easily, and am > happy to do so. The script also removes trailing whitespace from lines, of > which we also appear to have quite a lot. > > But doing this will create some large commit messages and make comparing > files with past versions noisier. It can also cause svn conflicts if people > have modified files they have not yet committed, unless they run the cleanup > script against their own working dir before doing svn update. > > So, option (a) or (b)? > > Regards, Simon > > -- http://www.irian.at Your JSF powerhouse - JSF Consulting, Development and Courses in English and German Professional Support for Apache MyFaces
