[ 
https://issues.apache.org/jira/browse/MYFACES-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611893#action_12611893
 ] 

Leonardo Uribe commented on MYFACES-1853:
-----------------------------------------

The objective of this patch is rename the files:

src/main/resources/META-INF/rsc/facelet-dev-debug.xml
src/main/resources/META-INF/rsc/facelet-dev-error.xml 

with

src/main/resources/META-INF/rsc/myfaces-dev-debug.xml
src/main/resources/META-INF/rsc/myfaces-dev-error.xml 

This solve the confusion with facelets error and debug page.

The second part is allow that the user could define its own resource template 
adding the context params:

org.apache.myfaces.DEBUG_TEMPLATE_RESOURCE
org.apache.myfaces.ERROR_TEMPLATE_RESOURCE

so the user can customize the template pages used.

> ErrorPageWriter causes Facelets/MyFaces confusion
> -------------------------------------------------
>
>                 Key: MYFACES-1853
>                 URL: https://issues.apache.org/jira/browse/MYFACES-1853
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: General
>    Affects Versions: 1.2.2
>         Environment: MyFaces 1.2.2
> Facelets 1.1.3
> Tomcat 6.0.14
>            Reporter: Michael Heß
>            Assignee: Leonardo Uribe
>         Attachments: patchFacesServletErrorHandling2.patch
>
>
> I just stumbled upon some weired problem. I have a rather basic myfaces
> 1.2.2 + facelets 1.1.3 setup. What I tried to achieve, is to NOT have
> either Facelets nor MyFaces handle any of the error 500 scenarios.
> Right now, in case of error 500 I have a facelets error page. "An Error
> Occured", and collapsable trees for the components etc. You know the
> drill.
> So I decided to disable debugging in facelets, by switching
> context-parameter facelets.DEVELOPMENT to false. This was the first moment
> I got confused, because devmode was already disabled.
> BUT: The error page definetly states "Generated by Facelets" in the lower
> right corner.
> I spent the last hour tracking this down. So far I have confirmed that the
> FaceletsViewHandler does not trigger the generation of said errorpage. So
> I searched some more, and found javax.faces.webapp._ErrorPageWriter to be
> the culprit. The problem is, that it seems to be a copy of the Facelets
> DevTools class. And furthermore the filename of the error-template has
> been copied as well. It's
> "META-INF/rsc/facelet-dev-error.xml"
> on both myfaces as well as facelets. I have checked the template included
> with myfaces and it is clearly different from the one included with
> facelets. So my best guess right now (I have not confirmed this any
> further) is, that MyFaces loads the template from facelets.jar due to some
> unlucky webapp classloader situation.
> Although the solution to my current problem is most likely to just disable
> debugging in myfaces as well, I would like to strongly advise to change
> the filename of the MyFaces error-template. This really confused me a lot.
> :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to