[ 
https://issues.apache.org/jira/browse/TRINIDAD-1217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631576#action_12631576
 ] 

Scott O'Bryan commented on TRINIDAD-1217:
-----------------------------------------

Sure.  First off, supressStyleSheet isn't available to the File Cache.  Second, 
even if we made it available, we want to use a cached version of the stylesheet 
object whenever possible.  Because the caching mechanism uses the date on the 
file as the criteria for whether the item in the cache is current or not, not 
writing out this file will force us to recalculate the stylesheet every time in 
order to get the SkinId.  This could cause a huge performance hit.

Like I say, I do agree it would be preferable to not generate the stylesheet at 
all, but doing so would require us to sever the relationship between the 
stylesheet object and it's cache file.  I did not do that as part of this bug 
fix, but I'll be sure to log a jira ticket to do it in case someone gets 
ambitious.  This fix will solve, however, the root problem with Portal encoded 
URL's being served up in servlet stylesheets.


> in portals stylesheet generated in the producer even when skin matches and 
> suppress is true
> -------------------------------------------------------------------------------------------
>
>                 Key: TRINIDAD-1217
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1217
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 1.0.9-core, 1.2.9-core
>            Reporter: Jeanne Waldman
>            Assignee: Jeanne Waldman
>         Attachments: TRINIDAD-1217_MAIN.patch
>
>
> Remember that the same web-app is used in both portlet and servlet
> environment. So say we run this web-app as portlet first and the producer
> skin matches the consumer, so the producer shares the css generated by the
> consumer (ie the producer css is not being used by the producer, but it's
> generated anyway because of this bug - note that the url in the css is one of
> the funny portlet url (starts with wsrp_rewrite)). So far so good here.
> Now access the web-app as servlet. Since the css was already generated by the
> producer (when accessed as portlet), adfv doesn't generate a new stylesheet -
> but the urls to the icons are wrong.
> e.g.,
> .x1n
> {...;background-image:url(wsrp_rewrite?wsrp-urlType=resource&wsrp-url=http%3A%2F%2F
> localhost%3A8988%2Fdiv%2Fportletresource%2FC%253A130.35.95.52%253A2cb0f
> 9b5%253A11ac1ce2de8%253A-7ffb%2FS%253A130.35.95.52%253A-2cbc5940%25
> 3A11ac6466884%253A-7fff%253AE%253Aiadf_jsf__untitled1_jspx%253A130.35.95.5
> 2%253A2cb0f9b5%253A11ac
> 1ce2de8%253A-7ffa%2Fadf%2Fimages%2Fclose.gif&wsrp-requiresRewrite=false/wsrp_rewrite)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to