Problems with ValueBindingValueExpression and ValueExpressionValueBinding -------------------------------------------------------------------------
Key: TRINIDAD-1253 URL: https://issues.apache.org/jira/browse/TRINIDAD-1253 Project: MyFaces Trinidad Issue Type: Bug Affects Versions: 1.2.9-core, 1.2.10-core Environment: All Reporter: Blake Sullivan The implementations of ValueBindingValueExpression and ValueExpressionValueBinding have several problems: ValueBindingValueExpression doesn't correctly implement StateHolder and Serializable. The returned class should implement the interfaces only if the class that it delegates to implements them (it currently always implements Serializable and never implements StateHolder). Determining which implementation class to create should be hidden behind a factory method. ValueBindingValueExpression should implement toString() to aid in debugging ValueExpressionValueBinding's problems are more extensive. It does not implement equals() it does not implement hashCode() It does not implement toString() Similarly to ValueBindingValueExpression it doesn't return implementations that implement StateHolder and/or Serializable if the ValueExpression that it is delegating to does. Determining which implementation class to create should be hidden behind a factory method. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.