looks good so far. I just wonder if this: + Locale locale = getLocale(); + if (null == locale) + { + RequestContext reqContext = RequestContext.getCurrentInstance(); + if (reqContext != null) + { + locale = reqContext.getFormattingLocale(); + } + if (locale == null) + { + locale = context.getViewRoot().getLocale(); + } + }
could be moved to a private function, since some other place is doing the same, I think -M On Tue, Oct 21, 2008 at 9:46 PM, Anita Anandan <[EMAIL PROTECTED]> wrote: > Hi all - > > I was wondering if one of the Trinidad committees could take a look at > trinidad-1262 (https://issues.apache.org/jira/browse/TRINIDAD-1262)? It > needs to be reviewed and committed. > > Thanks > Anita > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf