[
https://issues.apache.org/jira/browse/TOMAHAWK-1365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643168#action_12643168
]
Simon Kitching commented on TOMAHAWK-1365:
------------------------------------------
Sorry, please ignore previous comment; I hadn't looked carefully enough at your
patch & comments.
AIUI, the problem is when using Tomahawk with JSF1.2. In this case, JSF1.2
implementations (both Mojarra and Myfaces 1.2.x) generate conversion-failure
messages by replacing {0} with the full clientId of the component.
Myfaces 1.1.x however replaces {0} with just the clientId of the component.
Tomahawk's custom t:messages component has a special feature to replace the
component id in a message with the component's associated label. But it only
looks for the component's plain id, ie doesn't remove the whole clientId when
it does its message replacement.
Is this right? If so, does your patch work for both myfaces 1.1.x (just
component id) and myfaces 1.2.x (clientId)?
> Input field id in error messages is not properly replaced with label text
> -------------------------------------------------------------------------
>
> Key: TOMAHAWK-1365
> URL: https://issues.apache.org/jira/browse/TOMAHAWK-1365
> Project: MyFaces Tomahawk
> Issue Type: Bug
> Components: Message(s)
> Affects Versions: 1.1.8-SNAPSHOT
> Reporter: Val Blant
> Attachments: TOMAHAWK-1365.patch
>
>
> When we have a label associated with an input field via the 'for' attribute
> on the label, the client id substitution is not properly handled by
> org.apache.myfaces.renderkit.html.ext.HtmlMessageRenderer.findInputId().
> The problem is that when an error message is put together by a converter,
> javax.faces.convert._MessageUtils.getLabel() places the full clientId of the
> input component into the message text, whereas HtmlMessageRenderer replaces
> only the id with the label text.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
