Leonardo Uribe schrieb:
> Hi,
>
> I was running the needed tasks to get the 1.1.8 release of Apache
> MyFaces Tomahawk out.

Some initial test results:

The tomahawk-1.1.8 jar works well with Facelets + Mojarra1.2.0_09 + java1.6.

For the "staging repo" files deployed here:
  http://people.apache.org/~lu4242/tomahawk118
<http://people.apache.org/%7Elu4242/tomahawk118>
The binary jar license, manifest all look ok.
Checksums all look ok.

Oddly, the NOTICE file in the binary jarfile has nothing but the
standard ASF claim. However the NOTICE in the source jar has a lot more
credits in it. Looks like the NOTICE in the binary file could be wrong...

And on both NOTICE files, it says "copyright 2004-2007" which should
probably be updated.


I'm not convinced about this change to the tomahawk pom:

    <!-- Transitive dependency from commons-fileupload.
    in 1.2 it was declared optional, but t:inputFileUpload
    uses it indirectly, so it is necessary to include it
    in our pom as runtime dependency  -->
    <dependency>
      <groupId>commons-io</groupId>
      <artifactId>commons-io</artifactId>
      <version>1.3.2</version>
      <scope>runtime</scope>
    </dependency>

I think that this should indeed be an optional dependency; if someone
wants to use Tomahawk but not use the t:inputFileUpload, then why should
we force commons-io to be included in their classpath?

Regards,
Simon

-- 
-- Emails in "mixed" posting style will be ignored
-- (http://en.wikipedia.org/wiki/Posting_style)

Reply via email to