[ https://issues.apache.org/jira/browse/TOMAHAWK-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12650420#action_12650420 ]
Leonardo Uribe commented on TOMAHAWK-1356: ------------------------------------------ If you wish to use the comment text you have typed (shown below), please copy it now. This text will be lost when you leave this screen. I did the same as commons project. Now adds two entries: X-Compile-Source-JDK: 1.4 X-Compile-Target-JDK: 1.4 > Add target java version to MANIFEST.MF > -------------------------------------- > > Key: TOMAHAWK-1356 > URL: https://issues.apache.org/jira/browse/TOMAHAWK-1356 > Project: MyFaces Tomahawk > Issue Type: Improvement > Affects Versions: 1.1.7 > Reporter: Simon Kitching > Priority: Minor > > The tomahawk jars are compiled with -target set appropriately (1.4 for the > "old" tomahawk, 1.5 for "tomahawk12"). However this information is not > available in the MANIFEST.MF file. > It would be nice to add this info to the jarfile so that people can see > clearly what JVM is required. All the apache commons libs do this. Actually, > it would be nice to add all the same settings that commons jars add to > MANIFEST.MF > Note that it is possible to tell what version of java the code generates by > using > javap -verbose -classpath {jarfilename} {some-class-in-jar} > which will print something like > SourceFile: "HtmlInputTextTag.java" > minor version: 0 > major version: 49 > The major version number can then be looked up to determine what java version > the class is compatible with. But it's not very convenient. > I vaguely remember something like the "file" command under linux reporting > the java version, but I can't get that to work at the moment. > This is related to TOMAHAWK-1354 > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.