[
https://issues.apache.org/jira/browse/MYFACES-2100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12652712#action_12652712
]
Paul Pogonyshev commented on MYFACES-2100:
------------------------------------------
Thanks for the quick reply.
About wrapper: you are probably right, but it would be nice if there was a
wrapper abstract class in impl, because Application interface is kinda large.
Also, having one in the library itself would ease upgrades. With custom class,
when upgrading, I'd have to add wrappers/delegates for all new methods. With
library-provided class this would be automatic.
About final: I'm not sure it gives any speed boost for "virtual" methods (i.e.
in Java those you access without knowing exact class of an object). Though I
admit I don't really know.
> unnecessary final methods in ApplicationImpl (maybe elsewhere too)
> ------------------------------------------------------------------
>
> Key: MYFACES-2100
> URL: https://issues.apache.org/jira/browse/MYFACES-2100
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 1.2.5
> Reporter: Paul Pogonyshev
> Priority: Minor
>
> When trying to upgrade to MyFaces 1.2.5 from 1.1.5 I get several instances of
> 'overridden method is final' compilation errors for custom subclass of
> ApplicationImpl. E.g. I override createConverter() method to post-apply
> custom setters to results of super.createConverter().
> Are there any good reasons these methods are now final? Because if this is
> not fixed (i.e. reverted to previous non-final methods) I will have to
> reimplement the whole Application class, which sure sucks a lot.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
