Re: [Trinidad] Build Broken?

[Jeanne Waldman]

This checkin broke the golden files. ckormos, do you mind taking a look? Thanks, Jeanne Revision: 820104 Author: ckormos Date: 2:59:10 PM, Tuesday, September 29, 2009 Message: fix for [TRINIDAD-1520] - NPE from Google Bot (unknown agent) - by default, the properties of AgentImpl initialized with "unknown" values. ---- Modified : /myfaces/trinidad/trunk/trinidad-api/src/main/java/org/apache/myfaces/trinidad/context/Agent.java Modified : /myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/agent/AgentFactoryImpl.java Modified : /myfaces/trinidad/trunk/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/agent/AgentImpl.java Jeanne Waldman wrote, On 10/5/2009 11:06 AM PT: I also see:             <label                  class="p_OraHiddenLabel"                  for=""                 >               test-shortDesc             </label> is removed. The common denominator is that all the test-failures are in the IE tests. I don't see any checkins where this would have obviously caused this failure. Jeanne Waldman wrote, On 10/5/2009 10:56 AM PT: I see the same thing. It seems the change was: Mamallan Uthaman wrote, On 10/1/2009 6:39 PM PT: Hi, I am getting golden-file mismatch errors (refer below) while building the Trinidad trunk. is the build broken? Tests run: 821, Failures: 106, Errors: 0, Skipped: 0 Branch-1.2.12.2 build seems ok. Thanks Mamallan