On Mon, Oct 26, 2009 at 8:48 PM, Martin Marinschek <mmarinsc...@apache.org> wrote: > Hi Matthias, > > that has not been discussed on the EG, so I can't confirm your version > of the code. However, it seems reasonable to me.
OK, yeah, I just did refactoring :-) not added anything (wild). thanks for the review. > As I see from the > issue tracker, Ed already responded (he's been faster there than with > other MyFaces team issues recently ;), so I guess there is no need for > speeding him up. I know :-) thanks for the pointer! -Matthias > > > regards, > > Martin > > On 10/27/09, Matthias Wessendorf <mat...@apache.org> wrote: >> Hi, >> >> some of the hidden secrets of the new spec have been forgotten to be >> spec'd out :-( >> >> While checking on MyFaces's setParent() implementation, I decided to >> do a little clean up. >> >> Please see the patch here: >> https://issues.apache.org/jira/browse/MYFACES-2389 >> >> Generally I am wondering about the previous implementation as nothing >> like that has been mentioned in the spec at all. >> Can the MyFaces EG members confirm that this version is correct ? >> >> Would be also good if they were able to speed up on this ticket as well: >> https://javaserverfaces.dev.java.net/issues/show_bug.cgi?id=1384 >> >> Greetings, >> Matthias >> >> -- >> Matthias Wessendorf >> >> blog: http://matthiaswessendorf.wordpress.com/ >> sessions: http://www.slideshare.net/mwessendorf >> twitter: http://twitter.com/mwessendorf >> > > > -- > > http://www.irian.at > > Your JSF powerhouse - > JSF Consulting, Development and > Courses in English and German > > Professional Support for Apache MyFaces > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
