Thanks for committing the changes!
And thanks too for the really sweet thank you card from you and Anja!
Hope you got something nice for yourselves...
Happy Holidays!
- Pavitra
"Matthias Weßendorf (JIRA) wrote:" On 12/17/2009 12:34 AM PT:
[
https://issues.apache.org/jira/browse/TRINIDAD-1659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Weßendorf updated TRINIDAD-1659:
-----------------------------------------
Resolution: Fixed
Fix Version/s: 2.0.0-plugins
Assignee: Matthias Weßendorf
Status: Resolved (was: Patch Available)
Maven 2.0 plugin needs to add support for the new JSF 2.0 faces-config element
<partial-view-context-factory> element
---------------------------------------------------------------------------------------------------------------------
Key: TRINIDAD-1659
URL: https://issues.apache.org/jira/browse/TRINIDAD-1659
Project: MyFaces Trinidad
Issue Type: New Feature
Components: Plugins
Affects Versions: 2.0.0-plugins
Environment: Windows XP / JSF 2.0
Reporter: Pavitra Subramaniam
Assignee: Matthias Weßendorf
Fix For: 2.0.0-plugins
Attachments: Issue1659.patch
1. When tryjng to register a new factory - PartialViewContextFactory - in
faces-config-base.xml in trinidad-impl, I noticed that the generated
faces-config.xml did not have the factory element I added. It should look like
this (see last element)
<factory>
<faces-context-factory>org.apache.myfaces.trinidadinternal.context.FacesContextFactoryImpl</faces-context-factory>
<render-kit-factory>org.apache.myfaces.trinidadinternal.renderkit.CoreRenderKitFactory</render-kit-factory>
<partial-view-context-factory>org.apache.myfaces.trinidadinternal.context.PartialViewContextFactoryImpl</partial-view-context-factory>
</factory>
2. Turns out the transform20.xsl used to parse and generate the faces-config
was not looking for this new element. Code changes were required in
transform20.xsl
(maven-faces-plugin\src\main\resources\org\apache\myfaces\trinidadbuild\plugin\faces\resources)
3. Making the necessary updates in the file, compiling and using the plugin JARS to
build trinidad, worked. AS in the generated faces-config.xml did contain the entry I
added for the <partial-view-context-factory>
4. See attached patch
