hi all,
The cross validation feature makes usage of the *ReferencingStrategy
*implementations
to find the other value for the comparison in the validation. The
method *evaluateReferenceAndValidate
*implements 2 kinds of functionality the evaluation of the reference and
the validation (as the name indicates)
Shouldn't it be better that the *ReferencingStrategy *should only be used
for the evaluation of the references and that the call to the validations
(as it is already performed by the
*CrossValidationHelper*.*crossValidateCompareStrategy
*method) is made from the *AbstractCompareStrategy*.
The goal is that the *ReferencingStrategy *and implementations are
independent of the Cross validation feature so that they could be reused
(I'm thinking about a multiFieldValidation, more info follows) and a clearer
design is created.
I analyzed the usage of the different parameters and it should be possible
to have a method
*EvaluatedReference evaluateReference(MetaDataEntry metaDataEntry,
String validationTarget);*
that make the evaluation of the contents in validationTarget. The
*EvaluatedReference
*contains a reference to the *ProcessedInformationStorageEntry*, if it was a
*modelAwareEvaluation *and some other indications required in the Cross
compare validation method.
All the required changes are made to classes marked as
UsageCategory.INTERNAL so refactoring shouldn't have any impact on users of
the framework.
Regards
Rudy De busscher
