[ 
https://issues.apache.org/jira/browse/MYFACES-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804664#action_12804664
 ] 

Jakob Korherr commented on MYFACES-2504:
----------------------------------------

Normally you just have the ExternalContext for the ServletContext and for the 
PortletContext, so the patch should be ok here.

You don't have to make the method synchronized, but you can store the value in 
a static variable after the first invocation since the value won't change. 
There are some classes in MyFaces which all hold the configuration values in a 
static variable after the first invocation or after the class is loaded (e.g. 
org.apache.myfaces.util.ExternalSpecifications). Furthermore it could be more 
expensive for the container to call this method synchronized than to invoke it 
many times at the same time. Also this is not problematic at all.

> Google App Engine Support
> -------------------------
>
>                 Key: MYFACES-2504
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2504
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-252, JSR-314
>    Affects Versions: 1.2.8, 2.0.0-alpha
>         Environment: Google App Engine 1.3
>            Reporter: Ali Ok
>            Priority: Minor
>         Attachments: 2504-2.diff, 2504.diff
>
>
> Support for Google App Engine for MyFaces 1.2 and 2.0.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to