-1. I really don't like it. It should be an implementation detail of the ChangeManager to either replace/chain the attribute change in the addComponentChange (or any other change for that matter). We have an implementation on our project doing just that. That method would make no sense for our use case and would introduce backward compatibility issues. I could change my opinion, but I'd like a detailed use case as of why this cannot be just an implementation detail before I do.
Regards, ~ Simon On Wed, Apr 7, 2010 at 5:17 PM, Yuan Gao <yuan....@oracle.com> wrote: > hi, > > For JIRA 1761 (https://issues.apache.org/jira/browse/TRINIDAD-1761), we > propose to add this API to the ChangeManager interface: > /** > * Replace an AttributeComponentChange if it's present. > * > * @param facesContext > * @param uiComponent > * @param attributeComponentChange > * @return the old change instance > */ > public AttributeComponentChange > replaceAttributeChangeIfPresent(FacesContext facesContext, > UIComponent uiComponent, > AttributeComponentChange attributeComponentChange); > > > Let me know what do you think about it. > > Thanks, > -Yuan > > >
