[ 
https://issues.apache.org/jira/browse/MYFACES-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12868108#action_12868108
 ] 

Jan-Kees van Andel commented on MYFACES-2714:
---------------------------------------------

Hi Leonardo,

I don't see any issues, except two small ones:

1 The SNAPSHOT dependency for the JS plugin

2 The line: log.fine("Cannot evaluate EL expression 
"+convertToExpression(expressionList)+ " in resource " + 
getLibraryName()+":"+getResourceName());
looks like it "swallows" EL errors. I see that an event is published, but it 
looks like some information is lost in the event.
Log.error might be more appropriate.

But, I must admit, I have only looked at the code, I haven't tested it in a 
running application.

I'm +1 on committing this patch.

> Include uncompressed jsf.js file and use it when development mode is used
> -------------------------------------------------------------------------
>
>                 Key: MYFACES-2714
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2714
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-314
>    Affects Versions: 2.0.0
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>         Attachments: MYFACES-2714-2.patch, MYFACES-2714-3.patch
>
>
> Reading some blogs about jsf 2.0, I notice mojarra include an uncompressed 
> jsf.js file and use it when development mode is used. It is difficult to 
> debug myfaces javascript for users and I think it is worth to do it too.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to