On Tue, Jun 8, 2010 at 9:17 AM, Ali Ok <al...@aliok.com.tr> wrote: > Hi, > myfaces-shared HtmlTextRendererBase > : http://svn.apache.org/repos/asf/myfaces/shared/trunk/core/src/main/java/org/apache/myfaces/shared/renderkit/html/HtmlTextRendererBase.java > > tomahawk HtmlTextRenderer > : http://svn.apache.org/repos/asf/myfaces/tomahawk/trunk/core20/src/main/java/org/apache/myfaces/renderkit/html/ext/HtmlTextRenderer.java > I saw these two long before, and decided to not to follow that approach. > Files are almost identical, even if one extends another. > As you see, shared HtmlTextRendererBase is not much extensible, ie. not > fragmented into atomic parts or smthg. > I want to use that base in my project too. So I made very simple > modifications on that class: divided the long renderInput method into two > protected methods without changing the behavior. > Is it ok to do that?
sure, big methods are always a pita. > I will create a JIRA ticket and post the patch. +1 -M > And I just wonder why authors kept that long method and copy-pasted it on > Tomahawk? Is there something I'm not aware of? > Regards, > -- > My Blog: http://blog.aliok.com.tr > Twitter: http://twitter.com/aliok_tr > > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
