[ 
https://issues.apache.org/jira/browse/TRINIDAD-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12891370#action_12891370
 ] 

Jeanne Waldman commented on TRINIDAD-1860:
------------------------------------------

I reviewed the patch and some of the style selectors that end in Icon but are 
styles still exist.

Search for "Icon {" in the file.

e.g.,
.CBIconErrorIcon {
    -tr-rule-ref: selector(".CBIconLook:alias");
    -tr-rule-ref: selector(".CBIconError:alias");
    -tr-rule-ref: selector(".CBIconCommon");
}
.CBIconInfoIcon {
    -tr-rule-ref: selector(".CBIconLook:alias");
    -tr-rule-ref: selector(".CBIconInfo:alias");
    -tr-rule-ref: selector(".CBIconCommon");
}
.CBIconWarningIcon {
    -tr-rule-ref: selector(".CBIconLook:alias");
    -tr-rule-ref: selector(".CBIconWarning:alias");
    -tr-rule-ref: selector(".CBIconCommon");
}
.CBIconRequiredIcon {
}
.CBIconQuickSelectIcon {
}
.CBIconQuickSelectDisabledIcon {  
}

> Rename wrong style names in casablanca skin
> -------------------------------------------
>
>                 Key: TRINIDAD-1860
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-1860
>             Project: MyFaces Trinidad
>          Issue Type: Bug
>          Components: Skinning
>    Affects Versions: 1.2.13-core , 2.0.0-alpha-2
>            Reporter: Marius Petoi
>            Priority: Trivial
>             Fix For: 1.2.14-core , 2.0.0.3-core
>
>         Attachments: casablancaIconStyleNames.patch
>
>
> Some style names in casablanca skin are not properly named. Style names 
> should not end in Icon.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to