[ https://issues.apache.org/jira/browse/MYFACES-2774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896690#action_12896690 ]
Leonardo Uribe commented on MYFACES-2774: ----------------------------------------- Hi Marius The patch still has a bug. I'll explain it in detail. The test looks like this: <ui:composition> <h:outputText id="start" value="Start"/> <c:if test="#{employee.management}"> <h:form id="form"> <h:commandButton id="button" action="test" rendered="#{true}"/> </h:form> </c:if> <h:outputText id="end" value="End"/> </ui:composition> So, "start" and "end" component should always be rendered. I created two tests, one that simulates "#{employee.management}" go from false to true and viceversa. Both fails, because "start" and "end" are trimmed from component tree. > Remove MARK_DELETED attribute from the component > ------------------------------------------------ > > Key: MYFACES-2774 > URL: https://issues.apache.org/jira/browse/MYFACES-2774 > Project: MyFaces Core > Issue Type: Improvement > Components: General, JSR-314 > Affects Versions: 2.0.0 > Reporter: Marius Petoi > Priority: Minor > Attachments: markDeletedFaceletContext.patch, > markDeletedFaceletContext2.patch, markDeletedFaceletContext3.patch, > markDeletedFaceletContext4.patch, markDeletedFaceletContext5.patch, > markDeletedFaceletContext6.patch, markDeletedFaceletContext7.patch > > > The ComponentSupport.MARK_DELETED attribute is used only inside one request. > It doesn't need to be saved in the state. It should be removed from the > attributes of the component. Instead a list of components marked for deletion > should be included in the FaceletContext. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.