Leo no Problem I could work around that issue in my oamSubmit externalisation code by adding the factory to the tests themselves instead of altering the test framework. Jakob will check my oamSubmit patch before committing though (It went to deep into the core, I want to have a second eye on it)

But I agree both factories should be added per default in a jsf2 config to the tests.

Werner


Am 10.08.10 02:08, schrieb Leonardo Uribe:
Hi

I checked this one and we should provide this factories on myfaces test
by default:

MockPartialViewContextFactory
MockVisitContextFactory

I had planned these changes, but first it was necessary to do a refactor
on current files. The issue to solve this one is MYFACESTEST-24

regards,

Leonardo Uribe

2010/8/5 Werner Punz <werner.p...@gmail.com <mailto:werner.p...@gmail.com>>

    Nada, I just use whatever is defined by the maven poms in the core
    project.

    The failure occurred due to my code, but the code from me is correct
    the test fails illegally here because it cannot get the
    PartialViewContextFactory, which should be present by JSF2 definition.
    My code just triggered it because it probably was the first
    component related code which tried to reach the PartialViewContext.

    Werner


    Am 05.08.10 12:22, schrieb Matthias Wessendorf:

        have you done an svn up on the test project?
        Last week it caused also a build failure.

        -M

        On Thu, Aug 5, 2010 at 12:09 PM, Werner
        Punz<werner.p...@gmail.com <mailto:werner.p...@gmail.com>>  wrote:

            Hi do we have a bug here, I have not really dug into the
            root of the problem
            but I assume we have a hole in what the mockups provide.
            I am working on the oamsubmit issue, and also because it is
            connected I am
            working on double include prevention code for the ppr case.
            But now I have run into this:

            java.lang.IllegalArgumentException: no factory
            javax.faces.context.PartialViewContextFactory configured for
            this
            application.
               at
            javax.faces.FactoryFinder.getFactory(FactoryFinder.java:177)
               at
            
org.apache.myfaces.test.mock.MockFacesContext20.getPartialViewContext(MockFacesContext20.java:100)
               at
            
org.apache.myfaces.shared_impl.renderkit.html.util.ResourceUtils.renderMyfacesJSInlineIfNecessary(ResourceUtils.java:185)


            It seems to me that we do not have a
            PartialViewContextFactory and hence no
            PartialViewContext currently in our mockup 2.0, right?

            Werner











Reply via email to