[
https://issues.apache.org/jira/browse/MYFACES-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12896877#action_12896877
]
Stan Silvert commented on MYFACES-2860:
---------------------------------------
Leonardo,
I don't see how it makes a difference where the classes came from. Did you find
something in the spec that says an annotation is treated differently based on
whether it is in WEB-INF, META-INF, or JSF impl? Perhaps ordering is a concern?
What you have would be an improvement, but you are still scanning twice. If I
just provide you with a collection of classes then you have to scan the classes
for the annotations you are interested in. But on my end I already know which
annotations are in each class. If you give me an annotation, I can tell you
which classes in a deployment contain that annotation.
Also, I don't need the ExternalContext if you give me the ServletContext in the
constructor.
> Provide AnnotationScanner interface
> -----------------------------------
>
> Key: MYFACES-2860
> URL: https://issues.apache.org/jira/browse/MYFACES-2860
> Project: MyFaces Core
> Issue Type: Improvement
> Components: JSR-314
> Affects Versions: 2.0.1
> Reporter: Leonardo Uribe
> Assignee: Leonardo Uribe
> Attachments: jboss-myfaces.zip, Myfaces-2.0-jsf.deployer.zip,
> MYFACES-2860-1.patch
>
>
> Looking integration of myfaces with JBoss AS6, it was notice myfaces does not
> have a way to override the annotation configurator.
> Ri has a class called AnnotationProvider with this methods:
> public AnnotationProvider(ServletContext sc)
> abstract public Map<?> getAnnotatedClasses(Set<URL> urls)
> the documentation says it is possible to override using this type of
> constructor.
> public AnnotationProvider(ServletContext sc, AnnotationProvider parent)
> We should provide something similar (let's call it AnnotationScanner because
> its objective is scan for annotations).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
