[ https://issues.apache.org/jira/browse/MYFACES-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12899399#action_12899399 ]
Jakob Korherr commented on MYFACES-2858: ---------------------------------------- As with MYFACESTEST-24, we can remove the setUpFactories() workaround for the PartialViewContextFactory. I will also do a snapshot deploy of MyFaces test to verify that this is updated in the repo too and that no-one has build problems because of that. > pointless oamsubmit inline rendering (patch available) > ------------------------------------------------------ > > Key: MYFACES-2858 > URL: https://issues.apache.org/jira/browse/MYFACES-2858 > Project: MyFaces Core > Issue Type: Improvement > Affects Versions: 2.0.2-SNAPSHOT > Reporter: Werner Punz > Assignee: Jakob Korherr > Fix For: 2.0.2-SNAPSHOT > > Attachments: > https___issues_apache_org_jira_browse_MYFACES-2858_externalizing_oamsubmit__.patch > > > We have had several functions rendered inline for ages, namely > appendHiddenInput oamSubmit, the autoscroll stuff etc... > I personally think the rendering of those functions as inline scripts is > pointless, blows up the browsers tremendously and > prevents that the affected scripts can be browser cached. > A quick look at the code revealed that there is basically nothing which would > prevent to externalize the scripts. My main problem is where to we handle the > auto append code. > My personal guess is we probably simply should add it as a resource > definitions to the commandLink, Button etc.. renderers, any ideas regarding > this? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.