[
https://issues.apache.org/jira/browse/MYFACES-2919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909297#action_12909297
]
Jakob Korherr commented on MYFACES-2919:
----------------------------------------
Hi Gurkan,
I provided another patch with a few minor changes from your original patch: I
changed the access to ServletContext.getAttribute() to use the ApplicationMap,
I changed the provided-scope to the compile-scope on the optional-dependencies
(because optional = true needs compile-scope) and I removed the call to
DefaultLifecycleProviderFactory.getLifecycleProviderFactory().getLifecycleProvider(externalContext);
from StartupServletContextListener, because we already do this a few lines
earlier in AbstractFacesInitializer.
Could you please check if the new patch works for you? If so, I'll commit it
asap ;)
Thanks,
Jakob
> LifecycleProvider Based Problems and Tomcat7 LifeCycleProvider Support
> ----------------------------------------------------------------------
>
> Key: MYFACES-2919
> URL: https://issues.apache.org/jira/browse/MYFACES-2919
> Project: MyFaces Core
> Issue Type: Bug
> Reporter: Gurkan Erdogdu
> Assignee: Jakob Korherr
> Attachments: MYFACES-2919-2.patch, patch.txt
>
>
> Patch content
> ----------------------
> 1- ResourceAnnotationLifecycleProvider : It does not check super class for
> annotations. It must examine super classes. This is specificed in Java EE 6
> specification, EE 5.2.5 Annotations and Injections.
> 2- TomcatAnnotationLifecycleProvider : isAvailable Method must catch
> "Throwable" and ignore them. Otherwise, it throws error/s that are not
> catched and calling code is not able to process other lifecycle providers.
> 3- StartupServletContextListener : Early initiliazation of lifecycle
> provider. Otherwise, it is not possible to use META-INF/services providers.
> 4- pom.xml : Adding Tomcat 7 libs.
> 5- Tomcat7AnnotationLifecycleProvider : Tomcat 7 based LifeCycleProvider
> implementation.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
