[
https://issues.apache.org/jira/browse/MYFACES-2931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12916359#action_12916359
]
Leonardo Uribe commented on MYFACES-2931:
-----------------------------------------
Hi Christian
Yes, the fix could possibly break existing applications but note the opposite
is also true, if we don't apply the fix, there are other examples that are
valid in syntax but fails (MYFACES-2753). After thinking a lot and checking the
documentation left from the original author of facelets, including check
facelets cvs and issue tracking, I think the right choice was apply it (really
that conclusion was very difficult to find, because that code is the less
documented but most important in facelets).
Other argument that suggest the fixed behavior is preferred is related to the
attributes of ui:include and ui:decorate tag. Note that ui:decorate has
"template" attribute, but ui:include has "src" attribute. Therefore, the first
one suggest the link points to a "template", but the second one suggest that it
points to a "part" or "page".
> Regression: Template areas get lost when using <ui:include>
> ------------------------------------------------------------
>
> Key: MYFACES-2931
> URL: https://issues.apache.org/jira/browse/MYFACES-2931
> Project: MyFaces Core
> Issue Type: Bug
> Components: General
> Affects Versions: 2.0.2
> Reporter: Christian Kaltepoth
>
> Template areas specified with <ui:define> are not visible in files that the
> template includes with <ui:include>.
> See the following example.
> The template:
> http://github.com/chkal/myfaces-tests/blob/vdl-insert-bug/src/main/webapp/template.xhtml
> The file included by the template:
> http://github.com/chkal/myfaces-tests/blob/vdl-insert-bug/src/main/webapp/header.xhtml
> The page using the template:
> http://github.com/chkal/myfaces-tests/blob/vdl-insert-bug/src/main/webapp/page.xhtml
> MyFaces 2.0.2 will show "Wrong Title" in the title div, which is the default
> value of the <ui:insert>. MyFaces 2.0.1 and Mojarra will instead display
> "Correct Title", which is the value definied in page.xhtml via <ui:define>.
> You can download an example application demonstrating this issue here:
> http://github.com/chkal/myfaces-tests/archives/vdl-insert-bug
> Start the app with:
> mvn jetty:run
> The page is then available here:
> http://localhost:9090/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
