+1 Sorry, I did not see that Jakob fixed the issue...
/JK 2010/12/6 Grant Smith <work.gr...@gmail.com> > +1 > > > On Sun, Dec 5, 2010 at 8:51 PM, Gerhard <gerhard.petra...@gmail.com>wrote: > >> +1 >> >> regards, >> gerhard >> >> http://www.irian.at >> >> Your JSF powerhouse - >> JSF Consulting, Development and >> Courses in English and German >> >> Professional Support for Apache MyFaces >> >> >> >> 2010/12/6 Leonardo Uribe <lu4...@gmail.com> >> >> Hi >>> >>> Somebody else who wants to vote? we need just one +1 PMC vote to release >>> these artifacts. >>> >>> Note without this artifacts, it is not possible to release myfaces core >>> 2.0.3 >>> >>> regards, >>> >>> Leonardo Uribe >>> >>> 2010/12/2 Mark Struberg <strub...@yahoo.de> >>> >>> +1 (for both the statement and the release) >>>> >>>> the <relativePath> is only a warning in maven3 and should be set if the >>>> referenced parent pom is usually a part of the reactor build. >>>> >>>> LieGrue, >>>> strub >>>> >>>> --- On Thu, 12/2/10, Jakob Korherr <jakob.korh...@gmail.com> wrote: >>>> >>>> > From: Jakob Korherr <jakob.korh...@gmail.com> >>>> > Subject: Re: [VOTE] release for myfaces builder plugin 1.0.8 >>>> > To: "MyFaces Development" <dev@myfaces.apache.org> >>>> > Date: Thursday, December 2, 2010, 11:48 AM >>>> > Hi, >>>> > >>>> > The mentioned problem originates in the fact that the >>>> > plugin-parent is >>>> > not the enclosing project of the plugins. >>>> > >>>> > To fix this, the plugin-poms have to specify a relativePath >>>> > element in >>>> > the parent section that references the correct pom. This is >>>> > a >>>> > "feature" of maven 3 and not a bug, because otherwise there >>>> > could be >>>> > build problems. >>>> > >>>> > I have just committed the necessary changes to fix this >>>> > problem, >>>> > however I think it is not that important and we can >>>> > continue with the >>>> > vote (Note that the workaround is use Maven 2). >>>> > >>>> > Regards, >>>> > Jakob >>>> > >>>> > 2010/12/1 Leonardo Uribe <lu4...@gmail.com>: >>>> > > Hi >>>> > > >>>> > > It is not a problem. Maybe there is something wrong >>>> > with Maven 3 (I'm still >>>> > > in maven 2). In theory, for any plugin, it should >>>> > compile parent module >>>> > > first and then the plugin, but it seems there is a >>>> > problem with that maven >>>> > > version, so we can continue with the vote. Anyway, >>>> > I'll set all parent >>>> > > plugin versions to 1.0.4. >>>> > > >>>> > > regards, >>>> > > >>>> > > Leonardo >>>> > > >>>> > > 2010/12/1 Jan-Kees van Andel <jankeesvanan...@gmail.com> >>>> > >> >>>> > >> +0 >>>> > >> I just checked out MyFaces on a new, clean laptop >>>> > with an empty Maven >>>> > >> repo. With an empty repo I can't build the >>>> > "maven-plugins" project. When I >>>> > >> first manually install the "maven-plugin-parent" >>>> > module and then build >>>> > >> "maven-plugins", it works okay. >>>> > >> I vote a +0 because I'm not sure if it's just an >>>> > unimportant Maven 3 issue >>>> > >> and I could easily work around it. I haven't yet >>>> > looked at the cause. It >>>> > >> could indicate a dependency issue. >>>> > >> This is the error I get: >>>> > >> [ERROR] The project >>>> > >> >>>> > org.apache.myfaces.buildtools:myfaces-i18n-plugin:1.0.1-SNAPSHOT >>>> > >> >>>> > >>>> (/Users/jankeesvanandel/projects/work/myfaces/build-tools/maven2-plugins/myfaces-i18n-plugin/pom.xml) >>>> > >> has 1 error >>>> > >> [ERROR] Non-resolvable parent POM: Could not >>>> > find artifact >>>> > >> >>>> > org.apache.myfaces.buildtools:myfaces-plugin-parent:pom:1.0.5-SNAPSHOT >>>> > and >>>> > >> 'parent.relativePath' points at wrong local POM @ >>>> > line 24, column 11 -> >>>> > >> [Help 2] >>>> > >> Regards, >>>> > >> Jan-Kees >>>> > >> >>>> > >> >>>> > >> Regards, >>>> > >> Jan-Kees >>>> > >> >>>> > >> 2010/12/1 Jakob Korherr <jakob.korh...@gmail.com> >>>> > >>> >>>> > >>> +1 >>>> > >>> >>>> > >>> Everything looks good! >>>> > >>> >>>> > >>> Regards, >>>> > >>> Jakob >>>> > >>> >>>> > >>> 2010/11/30 Leonardo Uribe <lu4...@gmail.com>: >>>> > >>> > +1 >>>> > >>> > >>>> > >>> > 2010/11/30 Leonardo Uribe <lu4...@gmail.com> >>>> > >>> >> >>>> > >>> >> Hi, >>>> > >>> >> >>>> > >>> >> I was running the needed tasks to get >>>> > the 1.0.8 release of Apache >>>> > >>> >> MyFaces Builder Plugin out. >>>> > >>> >> >>>> > >>> >> This release includes some minor >>>> > changes necessary to build myfaces >>>> > >>> >> core >>>> > >>> >> 2.0.x and >>>> > >>> >> other improvements like: >>>> > >>> >> >>>> > >>> >> - MYFACES-2955 Allow projects using >>>> > myfaces builder plugin to be open >>>> > >>> >> on >>>> > >>> >> Netbeans IDE 6.8 >>>> > >>> >> - MYFACES-2956 build-metadata goal >>>> > does not take into account exclude >>>> > >>> >> generated source >>>> > >>> >> directory on >>>> > myfaces-builder-plugin >>>> > >>> >> - MYFACES-2963 Set default templates >>>> > automatically when jsfVersion is >>>> > >>> >> 20 >>>> > >>> >> or 2.0 with >>>> > >>> >> myfaces-builder-plugin >>>> > >>> >> - MYFACES-2867 Migrate to Velocity >>>> > 1.6 >>>> > >>> >> - MYFACES-2938 Allow @JSFValidator >>>> > and @JSFConverter to define custom >>>> > >>> >> tagHandler class >>>> > >>> >> - MFCOMMONS-17 Add facelet function >>>> > findComponent (fix to allow put >>>> > >>> >> additional stuff on >>>> > >>> >> generated facelets-taglib) >>>> > >>> >> - MYFACES-2962 Descriptions of >>>> > components, attributes, etc. are >>>> > >>> >> missing in >>>> > >>> >> taglib.xml >>>> > >>> >> files generated by MyFaces Builder >>>> > Plugin >>>> > >>> >> >>>> > >>> >> Testing instructions are available at >>>> > [3]. >>>> > >>> >> >>>> > >>> >> Please note that this vote concerns >>>> > all of the following parts: >>>> > >>> >> 1. Maven artifact group >>>> > "org.apache.myfaces.buildtools" artifact >>>> > >>> >> "myfaces-builder-plugin" v1.0.8 [1] >>>> > >>> >> 2. Maven artifact group >>>> > "org.apache.myfaces.buildtools" artifact >>>> > >>> >> "myfaces-builder-annotations" v1.0.7 >>>> > [1] >>>> > >>> >> >>>> > >>> >> The artifacts were deployed to a >>>> > nexus repository ([1]). >>>> > >>> >> >>>> > >>> >> Please take a look at the "1.0.8" >>>> > artifacts and vote! >>>> > >>> >> >>>> > >>> >> Please note: This vote is "majority >>>> > approval" with a minimum of three >>>> > >>> >> +1 votes (see [3]). >>>> > >>> >> >>>> > >>> >> >>>> > ------------------------------------------------ >>>> > >>> >> [ ] +1 for community members who have >>>> > reviewed the bits >>>> > >>> >> [ ] +0 >>>> > >>> >> [ ] -1 for fatal flaws that should >>>> > cause these bits not to be >>>> > >>> >> released, >>>> > >>> >> and why.............. >>>> > >>> >> >>>> > ------------------------------------------------ >>>> > >>> >> >>>> > >>> >> Thanks, >>>> > >>> >> Leonardo Uribe >>>> > >>> >> >>>> > >>> >> [1] >>>> > >>> >> >>>> > >>> >> >>>> https://repository.apache.org/content/repositories/orgapachemyfaces-029/org/apache/myfaces/buildtools/ >>>> > >>> >> >>>> > >>> >> >>>> > >>> >> >>>> https://repository.apache.org/content/groups/staging/org/apache/myfaces/buildtools/ >>>> > >>> >> [2] http://www.apache.org/foundation/voting.html#ReleaseVotes >>>> > >>> >> [3] http://wiki.apache.org/myfaces/BuilderPluginRelease108 >>>> > >>> > >>>> > >>> > >>>> > >>> >>>> > >>> >>>> > >>> >>>> > >>> -- >>>> > >>> Jakob Korherr >>>> > >>> >>>> > >>> blog: http://www.jakobk.com >>>> > >>> twitter: http://twitter.com/jakobkorherr >>>> > >>> work: http://www.irian.at >>>> > >> >>>> > > >>>> > > >>>> > >>>> > >>>> > >>>> > -- >>>> > Jakob Korherr >>>> > >>>> > blog: http://www.jakobk.com >>>> > twitter: http://twitter.com/jakobkorherr >>>> > work: http://www.irian.at >>>> > >>>> >>>> >>>> >>>> >>> >> > > > -- > Grant Smith - V.P. Information Technology > Marathon Computer Systems, LLC. > >
