Thanks for the patch - let me take a quick look On Wed, Jan 26, 2011 at 3:34 AM, Pavitra Subramaniam < pavitra.subraman...@oracle.com> wrote:
> (resending as my first email to dev@myfaces bounced) > > Committers, > > Can you please review this patch and commit the changes if satisfactory? > Both Michael, who logged the issue, and I are facing issues with the > CacheRenderKit not overriding the new JSF 2.0 methods in FacesContext, nor > extending from FacesContextWrapper. > > The patch makes FacesContextFactoryImpl$CacheRenderKit extend from > FacesContextWrapper. > > Thanks > Pavitra > > -------- Original Message -------- Subject: [jira] Updated: > (TRINIDAD-1996) FacesContextFactoryImpl's FacesContext (CacheRenderKit) > needs to extend FacesContextWrapper not FacesContext Date: Tue, 25 Jan > 2011 21:24:44 -0500 (EST) From: Pavitra Subramaniam (JIRA) > <dev@myfaces.apache.org> <dev@myfaces.apache.org> Reply-To: MyFaces > Development <dev@myfaces.apache.org> <dev@myfaces.apache.org> To: > dev@myfaces.apache.org > > > [ > https://issues.apache.org/jira/browse/TRINIDAD-1996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > > Pavitra Subramaniam updated TRINIDAD-1996: > ------------------------------------------ > > Status: Patch Available (was: Open) > > > FacesContextFactoryImpl's FacesContext (CacheRenderKit) needs to extend > > FacesContextWrapper not FacesContext > > ------------------------------------------------------------------------------------------------------------ > > > > Key: TRINIDAD-1996 > > URL: https://issues.apache.org/jira/browse/TRINIDAD-1996 > > Project: MyFaces Trinidad > > Issue Type: Bug > > Affects Versions: 2.0.0-alpha-2 > > Reporter: Michael Freedman > > Attachments: FacesContextFactoryImpl.patch > > > > > > Currently Trinidad's FacesContextFactoryImpl creates a FacesContext of type > > CacheRenderKit (declared in same file). CacheRenderKit is declared as a > > class that extends FacesContext. Instead it should extend > > FacesContextWrapper. By not using the wrapper Trinidad breaks other > > instances in the hierarchy (lower than it) as it misses the wrapper > > delegation model. > > Note: When you make this change. also remove the now obsolete methods that > > merely delegate. > > Testcase: Portlet Bridge TCK tests don't run unless this code is changed > > to extend the Wrapper. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > > > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf
