[
https://issues.apache.org/jira/browse/MYFACES-2995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999056#comment-12999056
]
David Jencks commented on MYFACES-2995:
---------------------------------------
This looks ok to me although I don't like the amount of reflection that much.
A few comments:
- I don't see why FactoryFinderProvider is an abstract class rather than an
interface.
- I don't see why the api _FactoryFinderProviderFactory needs to know anything
about FactoryFinderProviderFactory. Since you are already using reflection to
poke around in the api, why not have FactoryFinderProviderFactory just set an
object field in the api class directly?
- I think I would make the tccl and optional replacement strategies more
similar by putting the tccl based code in a FactoryFinderProvider like object
set into _FactoryFinderProviderFactory by default.
I haven't tried this with geronimo yet but I think it will work.
> Make method of determinine app context in FactoryFinder pluggable
> -----------------------------------------------------------------
>
> Key: MYFACES-2995
> URL: https://issues.apache.org/jira/browse/MYFACES-2995
> Project: MyFaces Core
> Issue Type: Improvement
> Components: SPI
> Affects Versions: 2.0.3-SNAPSHOT
> Reporter: David Jencks
> Attachments: MYFACES-2995-FactoryFinderProvider-1.patch,
> MYFACES-2995.patch
>
>
> As discussed on dev list.... geronimo would like to explicitly mark component
> boundaries rather than relying on the TCCL changing.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
