[ 
https://issues.apache.org/jira/browse/TRINIDAD-2030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13001437#comment-13001437
 ] 

Andy Schwartz commented on TRINIDAD-2030:
-----------------------------------------

Fix committed:

http://svn.apache.org/viewvc?view=revision&revision=1070523

> Honor SKIP_ITERATION FacesContext property
> ------------------------------------------
>
>                 Key: TRINIDAD-2030
>                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2030
>             Project: MyFaces Trinidad
>          Issue Type: Improvement
>          Components: Components
>    Affects Versions: 2.0.0-beta-1
>            Reporter: Andy Schwartz
>            Priority: Minor
>         Attachments: trinidad-skip-iteration.patch
>
>
> As discussed in this MyFaces core issue:
> MYFACES-3036 Support SKIP_ITERATION FacesContext property
> The JSF-314 EG (and members of Mojarra and MyFaces) agreed to use the 
> "javax.faces.visit.SKIP_ITERATION" FacesContext property (during the 2.0 
> timeframe) to indicate that a tree visit should not trigger iteration in 
> iterating components like UIData/UIRepeat.  Opening this issue to request 
> that iterating Trinidad components (UIXIterator, UIXCollection) honor this 
> property as well.
> Note that Trinidad already handles this centrally in 
> UIXComponent.visitChildren:
>       // determine whether this visit should be iterating.  If it shouldn't, 
> don't
>       // even call the protected hook.  We currently don't iterate during the
>       // restore view phase when we are visiting all of the components.
>       boolean noIterate = (visitContext.getIdsToVisit() == 
> VisitContext.ALL_IDS) &&
>                           (context.getCurrentPhaseId() == 
> PhaseId.RESTORE_VIEW);
>       doneVisiting =  (noIterate)
>                         ? uixParentComponent._visitAllChildren(visitContext, 
> callback)
>                         : uixParentComponent.visitChildren(visitContext, 
> callback);
> This issue is requesting that we enhance the above "noIterate" test to also 
> check the SKIP_ITERATION property.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to