[ 
https://issues.apache.org/jira/browse/MYFACES-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133943#comment-13133943
 ] 

Mark Struberg commented on MYFACES-3368:
----------------------------------------

the sun conventions are 12 years old and partly archaic or even obsolete.

In fact the _ in front of variable names must (according to lots of sources) 
only be allowed for private members at best. The benefit is also questionable, 
but I guess it's ok to keep this old habit. But I've seen local variables and 
even method parameters wich _variable! This is just plain wrong (and ever was).
                
> enable 'standard' checkstyle checks in myfaces-core
> ---------------------------------------------------
>
>                 Key: MYFACES-3368
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3368
>             Project: MyFaces Core
>          Issue Type: Improvement
>    Affects Versions: 2.1.3
>            Reporter: Mark Struberg
>            Assignee: Mark Struberg
>
> We currently only have the 'minimal' checks enabled in core, which actually 
> only checks the correct license headers.
> We should go for the 'standard' checkstyle rules, even if this would take 
> some time to fix (found 1111 errors only in the first module).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to