Hi! The double-check-lock idiom was fundamentally broken up until Java5. With JSR-133 this got finally fixed.
We use this design pattern in our code since a long time (of course not always correct due to the missing 'volatile' declaration), but it really only works with Java5 upwards. So I'd suggest that we disable this very test in our checkstyle-rules. What we could also do is to just copy our ruleset from src/main/resources/default/ to src/main/resources/default2/ (2 because of jsf2 which requires java5) so we have rules for old (JSF-1 jdk1.4) and new (JSF-2 java5) projects. Same is true for the tobago rules of course. wdyt? [+1] yup drop the double-test-check idiom test from our checkstyle rules [0] don't care [-1] nope, keep it BECAUSE, ... here is my +1 LieGrue, strub
