[ 
https://issues.apache.org/jira/browse/MYFACES-3418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184653#comment-13184653
 ] 

Leonardo Uribe commented on MYFACES-3418:
-----------------------------------------

I did another alternative for this one. The idea is do not take into account 
ids from components descending UILeaf (html markup) in production by default 
and do not use the parameter. Maybe we can combine both strategies, allowing 
org.apache.myfaces.CHECK_ID_IN_PRODUCTION with these values:

true : Check all client ids, including UILeaf components
auto : Check only client ids of components that does not extends from UILeaf.
false : Do not check for duplicate ids in production.

I think the advantage of the "auto" mode is that improve performance and reduce 
memory usage, and catch all duplicate id relevant cases (remember that facelets 
generates ids always starting with j_id_ , which is a reserved prefix for 
generated ids).

If no objections I'll combine both patches and commit the resulting code soon.
                
> [perf] do not check for duplicate ids when saving view on production stage
> --------------------------------------------------------------------------
>
>                 Key: MYFACES-3418
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3418
>             Project: MyFaces Core
>          Issue Type: New Feature
>         Environment: myfaces trunk
>            Reporter: Martin Kočí
>            Assignee: Martin Kočí
>            Priority: Minor
>         Attachments: MYFACES-3418-alternative-1.patch, MYFACES-3418.patch
>
>
> see discussion here: 
> http://www.mail-archive.com/dev@myfaces.apache.org/msg52995.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to