UISelectOne.validateValue(...) optimised & refactored
-----------------------------------------------------

                 Key: MYFACES-3448
                 URL: https://issues.apache.org/jira/browse/MYFACES-3448
             Project: MyFaces Core
          Issue Type: Improvement
          Components: General
    Affects Versions: 2.1.5
            Reporter: David Law
            Priority: Minor


The UISelectOne.validateValue(...) code is not particularly human-readable to 
say the least.
Also, in the case of a match(the norm) the method this.isRequired() is called 
twice(!) if it returns false.
Patch attached. (100% tested for all permutations of match, isRequired & 
NoSelection)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to