Hi! I checked Leos original text and saw that the main issue is to update the contributors sections in the parent pom.
Thus I'm happy to cast a +1 LieGrue, strub PS: Leo, I've now commited the fixes in our checkstyle-rules. If you find time, can you please check them out and apply the proper // CHECKSTYLE:OFF and // CHECKSTYLE:ON on the problematic code regions? Would be cool if you could test this. I think this is a bit cleaner than to stretch our general coding style rules. txs and LieGrue, strub ----- Original Message ----- > From: Mark Struberg <strub...@yahoo.de> > To: MyFaces Development <dev@myfaces.apache.org> > Cc: > Sent: Monday, January 23, 2012 8:45 PM > Subject: Re: [VOTE] release for myfaces master pom v 13 > > If we only do this for the checkstyle stuff, then I'm -1, otherwise I'm > +1 (don't like to block other stuff) > > > > Reason: the checkstyle rules still miss the SuppressionCommentFilter and the > rules are pretty much blown up. > > This is partly my fault (didn't find time to fix that), but will do now. > > The idea is do enable the SuppressionCommentFilter in the checkstyle rules > and > use > > // CHECKSTYLE:OFF > dosomeDirtyStuff() > // CHECKSTYLE:ON > > > to partly disable the checkstyle verification on a local area. > > > Instead of this we currently have > > <!-- In MyFaces Core we need methods with more than 10 > parameters, for example when rendering client behaviors. --> > <module name="ParameterNumber"> > <property name="max" value="20" /> > </module> > > which is really only needed for 1 method I think ;) > > Will move this back to max 10 and add the comment stuff. > > LieGrue, > strub > > > > ----- Original Message ----- >> From: Martin Koci <martin.kocicak.k...@gmail.com> >> To: MyFaces Development <dev@myfaces.apache.org> >> Cc: >> Sent: Monday, January 23, 2012 7:38 PM >> Subject: Re: [VOTE] release for myfaces master pom v 13 >> >> +1 >> >> >> Leonardo Uribe píše v St 18. 01. 2012 v 09:18 -0500: >>> Hi, >>> >>> I was running the needed tasks to get the version 13 release of Apache >>> MyFaces Master POM. >>> >>> This release is necessary to update the site information about MyFaces >>> contributors. >>> >>> Please note that this vote concerns all of the following parts: >>> >>> 1. Maven artifact group "org.apache.myfaces.myfaces" v 13 > [1] >>> >>> The artifacts are deployed to a nexus staging repository [1]. >>> >>> Please take a look at the version 13 pom and vote! >>> >>> Please note: This vote is "majority approval" with a minimum > of >> three >>> +1 votes (see [3]). >>> >>> ------------------------------------------------ >>> [ ] +1 for community members who have reviewed the bits >>> [ ] +0 >>> [ ] -1 for fatal flaws that should cause these bits not to be > released, >>> and why.............. >>> ------------------------------------------------ >>> >>> Thanks, >>> Leonardo Uribe >>> >>> [1] >> https://repository.apache.org/content/repositories/orgapachemyfaces-087/ >>> >> > https://repository.apache.org/content/groups/staging/org/apache/myfaces/myfaces/13/ >> >
