[ https://issues.apache.org/jira/browse/MYFACES-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223452#comment-13223452 ]
Leonardo Uribe commented on MYFACES-3136: ----------------------------------------- fixed as part of MYFACES-3488 > [perf] review UIComponentBase.getRendererType > ---------------------------------------------- > > Key: MYFACES-3136 > URL: https://issues.apache.org/jira/browse/MYFACES-3136 > Project: MyFaces Core > Issue Type: Improvement > Components: General > Affects Versions: 2.1.0-SNAPSHOT > Environment: myfaces core trunk > Reporter: Martin Kočí > Assignee: Leonardo Uribe > Priority: Minor > Fix For: 2.0.13, 2.1.7 > > Attachments: MYFACES-3136.patch > > > 1) method UIComponentBase.getRendererType is the most frequent, because all > encodeBegin, getRendersChildren and encodeAll l try to locate renderer > 2) getRendererType uses StateHelper.eval - but can be renderType > ValueExpression? If not, change StateHelper.eval to StateHelper.get > 3) should rendererType even be part of state saving? Each component I've ever > seen has setRendererType("com.foo.renderer") in constructor and/or VDL calls > setRendererType() after calling Application.createComponent(): If > rendererType is not part of state saving, replace StateHelper with attribute > 4) Cache getRenderer(FacesContext context) result anyway (I'll create > separate issue for this) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira