[
https://issues.apache.org/jira/browse/MYFACES-3199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225132#comment-13225132
]
Martin Kočí commented on MYFACES-3199:
--------------------------------------
a example:
<h:commandButton value="ok" action="#{testBean.actionNPE}" />
<h:commandButton value="ok"
actionListener="#{testBean.actionListenerNPE}" />
<h:commandButton value="ok">
<f:actionListener binding="#{actionListenerNPE}" />
</h:commandButton>
in all three cases returns exceptionQueuedEventContext.getComponent null in
ExceptionHandler
For action is exception wrapped into FacesException with message: "Error
calling action method of component with id " + clientId (ActionListenerImpl,
line 120)
For actionListeners are exception wrapped into FacesException with message:
"Exception while calling broadcast on component :" + getComponentLocation
(UIComponentBase line 430)
Goal:
1) get rid of FacesException wrapping with different messages and
2) queue source component where problem occurred
this issue (MYFACES-3199) should provide 2) - source component available within
exceptionQueuedEventContext.getComponent() - allows clients to format and
display error in unified manner
> Handling AbortProcessingException is unconsistent
> -------------------------------------------------
>
> Key: MYFACES-3199
> URL: https://issues.apache.org/jira/browse/MYFACES-3199
> Project: MyFaces Core
> Issue Type: Sub-task
> Components: General
> Environment: myface core trunk
> Reporter: Martin Kočí
> Assignee: Leonardo Uribe
> Fix For: 2.0.9, 2.1.3
>
> Attachments: UIViewRoot.patch
>
>
> UIViewRoot:
> try {
> source.broadcast(event);
> }
> catch (AbortProcessingException e)
> {
> ExceptionQueuedEventContext exceptionContext
> = new ExceptionQueuedEventContext(context, e, source,
> context.getCurrentPhaseId());
> context.getApplication().publishEvent(context,
> ExceptionQueuedEvent.class, exceptionContext);
>
> // Abortion
> return false;
> }
> Problem 1:
> <h:inputText valueChangeListener="#{bean.processValueChange}">
> MethodExpressionValueChangeListener wraps all exceptions to
> AbortProcessingException and therefore exception is queued
> Problem 2:
> <h:inputText >
> <f:valueChangeListener binding="#{bean}" />
> </h:inputText>
> ValueChangeListenerHandler does not wrap exception to
> AbortProcessingException and therefore exception is not queued in this block
> (but it is queued from phase executor but without component info)
> Problem 3: JSF spec 2.1 :
> "Clarification made: throwing an AbortProcessingException tells an
> implementation that no further broadcast of the
> current event occurs. Does not affect future events."
> But I think that code in UIViewRoot makes opposite: // Abortion return
> false;
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
