[ https://issues.apache.org/jira/browse/ORCHESTRA-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238099#comment-13238099 ]
Leonardo Uribe commented on ORCHESTRA-60: ----------------------------------------- Hi Cristian O, now I get it. sendRedirect() is used for internal and external URLs, but all internal URLs pass first through encodeRedirectURL(), so it is valid to add conversationContext param into that call. The rules for add conversationContext are already in orchestra and applies to encodeURL() too, so the change is valid. > Orchestra should implement RequestParameterResponseWrapper.encodeRedirectURL() > ------------------------------------------------------------------------------ > > Key: ORCHESTRA-60 > URL: https://issues.apache.org/jira/browse/ORCHESTRA-60 > Project: MyFaces Orchestra > Issue Type: Bug > Components: Conversation > Affects Versions: 1.5 > Reporter: Christian Kaltepoth > > Orchestra currently doesn't implement > RequestParameterResponseWrapper.encodeRedirectURL(). The API docs of > HttpServletResponse clearly state that encodeRedirectURL() should be called > before sending a redirect using sendRedirect(). Therefore the > conversationContext parameter is currently lost in these situations. > Corresponding PrettyFaces issue: > http://code.google.com/p/prettyfaces/issues/detail?id=125 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira