[
https://issues.apache.org/jira/browse/MYFACES-3501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13281152#comment-13281152
]
Martin Kočí commented on MYFACES-3501:
--------------------------------------
> In this case, ConverterException is special and has a meaning according to
> JSF spec, so I suppose this is
> incorrect
the code in RendererUtils is:
try
{
converter = findUIOutputConverter(facesContext, output);
}
catch (FacesException e)
{
throw new ConverterException(e);
}
this can only happen during "converter resolving", but spec says:
"ConverterException is an exception thrown by the getAsObject() or getAsText()
method of a Converter, to indicate that the requested conversion cannot be
performed." and therefore I think purpose of ConverterException is not the
indication that converter cannot be found.
But after checking it more, this tyr-catch looks like dead code:
findUIOutputConverter method cannot throw FacesException, only ELException
> Remove unncecessary exception wrapping
> --------------------------------------
>
> Key: MYFACES-3501
> URL: https://issues.apache.org/jira/browse/MYFACES-3501
> Project: MyFaces Core
> Issue Type: Sub-task
> Components: General
> Reporter: Martin Kočí
> Assignee: Martin Kočí
> Priority: Trivial
> Fix For: 2.0.14, 2.1.8
>
> Attachments: ActionListenerImpl.patch, RendererUtils.patch,
> TextInstruction.patch, UIComponentBase.patch
>
>
> Similar to MYFACES-3214:
> ld code uses:
> catch(Exception ex)
> {
> throw new FacesException("Could not retrieve value of component
> with path : "+
> getPathToComponent(component),ex);
> }
> to provide path to problematic component. With JSF 2.0 and exception handler
> is is not necessary (and only makes stacktrace harder to read), because:
> 1) exception is always queued with component instance (see MYFACES-3201 and
> MYFACES-3199)
> 2) every EL expression knows about it's location (MYFACES-3202)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
