Ok Max first of all thanks for letting me in.
I now have applied most of the patches with the exception of
TRINIDAD-2302 which as requested now is assigned to you, TRINIDAD-2252
(which already was implemented)
and TRINIDAD-2307 there I am not sure if the patch is correct, it looks
incorrect to me but I lack the deeper knowledge there. Can anyone have a
quick look at it, if it is correct?
Thanks a lot
Werner Punz
Am 08.01.13 15:41, schrieb Max Starets:
Hey Werner,
First, huge thanks for helping us out when we are swamped with working
on other projects!
Regarding TRINIDAD-2302: this is indeed a duplicate of TRINIDAD-2216,
and the patch for TRINIDAD-2302 seems to be better than the proposed
patch for TRINIDAD-2216. However, I wonder whether we could use an even
more optimized approach: since the ID is known in the Javascript method
that ultimately calls jsf.ajax.request(), could we just add the ID in
Javascript code on the fly if one is not present? This way won't
increase the content size (the ID is already rendered as part of the
javascript event handler call, so with the patch for TRINIDAD-2302 we
would be really rendering it twice).
You can assign TRINIDAD-2302 to me, and I will take care of it within
the next two weeks. However, if we need a fix urgently, I would not
object to the current patch for TRINIDAD-2302 being committed.
I am also +1 on the rest of the patches.
Thanks,
Max
On 1/8/2013 3:43 AM, Werner Punz wrote:
Hi following issues:
TRINIDAD-2349: TreeRenderer renders double html ids
https://issues.apache.org/jira/browse/TRINIDAD-2349
TRINIDAD-2348: HeadRenderer renders meta tags in wrong order for IE
https://issues.apache.org/jira/browse/TRINIDAD-2348
TRINIDAD-2252:
ViewDeclarationLanguageFactoryImpl$ChangeApplyingVDLWrapper does not
override non-abstract retargetMethodExpressions() causing composite
component actions not to fire
https://issues.apache.org/jira/browse/TRINIDAD-2252
TRINIDAD-2302: source component of ajax request is rendered without id
(causing javascript errors)
https://issues.apache.org/jira/browse/TRINIDAD-2302
TRINIDAD-2303: State saving skips facets (component resources).
https://issues.apache.org/jira/browse/TRINIDAD-2303
TRINIDAD-2307: Selectors that are classified as icons are not
correctly added as style.
https://issues.apache.org/jira/browse/TRINIDAD-2307
Werner
Am 07.01.13 16:59, schrieb Max Starets:
Hey Werner,
Would you mind listing the JIRA issues?
Thanks,
Max
On 1/7/2013 3:34 AM, Werner Punz wrote:
Hello, I know I have committer rights, but since it is not a project I
have not been actively involved in, I am asking first.
The issue is, that there is a handful of patches in Jira which I want
to merge into the main codebase of Trinidad which fix a number of
annoying issues.
Does anyone of the Trinidad devs have any objection that I do it?
Werner
