[ https://issues.apache.org/jira/browse/TRINIDAD-2359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13570630#comment-13570630 ]
Andy Schwartz commented on TRINIDAD-2359: ----------------------------------------- This patch: https://issues.apache.org/jira/secure/attachment/12567885/trinidad-2359.patch Fixes the isTestParamPresent() present by looking for the test parameter in the ExternalContext's request parameter map instead of in the RequestStateMap. I suppose we could rip this code out altogether, though perhaps this test could be useful for catching future regressions? > ClearRequestExternalContext wrapper applied unnecessarily > --------------------------------------------------------- > > Key: TRINIDAD-2359 > URL: https://issues.apache.org/jira/browse/TRINIDAD-2359 > Project: MyFaces Trinidad > Issue Type: Bug > Affects Versions: 2.0.1-core > Reporter: Andy Schwartz > Assignee: Andy Schwartz > Priority: Minor > Attachments: trinidad-2359.patch > > > GlobalConfiguratorImpl wraps the ExternalContext with a > ClearRequestExternalContext if it detects that Mojarra issue 493 (fixed back > in Mojarra 1.2.04) is present. > The Mojarra issue is described here: > http://java.net/jira/browse/JAVASERVERFACES-493 setRequest does not reset > request maps > Two problems with this: > 1. This issue was fixed in 2007, so it is unclear whether we should ever > bother applying this workaround. > 2. The code which detects the presence of this Mojarra issue is buggy. > As a result of #2, GlobalConfiguratorImpl always adds a > ClearRequestExternalContext wrapper, regardless of whether the old Mojarra > issue is present or not. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira