[ 
https://issues.apache.org/jira/browse/MYFACES-3402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634790#comment-13634790
 ] 

Leonardo Uribe commented on MYFACES-3402:
-----------------------------------------

ResourceHandlerImpl is not the one responsible to deal with the encoding in an 
ajax request. Checking this part, it seems the encoding is set in 
javax.faces.context.PartialResponseWriter.startDocument() and it is always 
utf-8. 

It looks like that part is wrong. The javadoc says: "... write the start of a 
partial response. ...." so in that sense is right, but it should not write the 
xml preamble there. Instead, it should write the preamble in 
PartialViewContextImpl.processPartialRendering and take as content type the 
character encoding of the writer.

Since this issue was not marked with component type JSR-314, it did not fell 
out of my radar. I'll check this one.
                
> Partial Response Writer always returns an <?xml version='1.0' 
> encoding='utf-8'?> ignoring the response encoding
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-3402
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3402
>             Project: MyFaces Core
>          Issue Type: Bug
>    Affects Versions: 2.0.10, 2.1.4
>            Reporter: Werner Punz
>         Attachments: JIRA-MYFACES-3402.patch
>
>
> While I was testing different ajax encodings I discovered that the Partial 
> Response writer always returns the header listed on the headline of this 
> issue. It ignores simply the original encoding.
> A blackbox test against Mojarra showed in that exact case the proper encoding 
> not UTF-8 static.
> I guess the fix simply should be to make this part of the partial response 
> writer more dynamic and to fetch
> the encoding in from the request header.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to