[ https://issues.apache.org/jira/browse/MYFACES-3786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13795121#comment-13795121 ]
Dora Rajappan commented on MYFACES-3786: ---------------------------------------- Sounds to me that you are replicating the scope handling of container in jsf. In future everything goes to container and the cdi&scope handling become obsolete or a failover. And for now this #4 and #5 are equally good. But how will you listen to the scope changes in jsf and perform clean up #preDestroy? When session expires perform a clean up and also perform the cleanup when the application is shutdown, renderesponse phase for view scoped instances and so forth. How about request and flowscope clean-ups? How about custom scopes? How will you determine the scope of jsf artifact that is in annotation and not even in faces-config to store it against a scope in #4 and #5? Scoping doubts are applicable for Validator/Convertor.ie a Validator in @RequestScoped Is scope Valid for StateManager or NavigationHandler? I analysed the patch. List<BeanEntry> injectedBeanStorage can be Map<Class<?>, List<BeanEntry>> injectedBeanStorage for ease of predestroy by Class<?> and object. > Web Container injection support should be provided for additional lifecycle > artifacts (not just managed beans) > -------------------------------------------------------------------------------------------------------------- > > Key: MYFACES-3786 > URL: https://issues.apache.org/jira/browse/MYFACES-3786 > Project: MyFaces Core > Issue Type: Task > Components: JSR-344 > Reporter: Leonardo Uribe > Assignee: Leonardo Uribe > Fix For: 2.2.0 > > Attachments: cdiELresolverWeb.zip, cdiELResolver.zip, > cdiPartialViewContext.war, cdiPartialViewContext.zip, cdi.patch, > cdiphaselistener1.patch, cdiphaselistener2.patch, cdirevised.patch, > cdiValidatorSource.zip, cdiValidator.war, MYFACES-3786-1.patch, > MYFACES-3786-2.patch, MYFACES-3786_bean-entry_draft_01.patch > > > This issue is all about how to inject beans into jsf artifacts. > See JSF 2.2 section 5.4.1 > The problem here is in some point we need to give the control to the > underlying environment to inject beans into the artifacts, but we don't know > much about how to properly do it, so we need to try with examples. -- This message was sent by Atlassian JIRA (v6.1#6144)